On 2024-11-10 21:46, Srinivasan Shanmugam wrote:
This patch adds the missing parameter descriptors to the functions
v4_0_5 _start, _stop, _set_unified_ring_funcs, and _set_irq_funcs.
Fixes the below with gcc W=1:
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c:996: warning: Function parameter or
struct member 'inst' not described in 'vcn_v4_0_5_start'
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c:1205: warning: Function parameter or
struct member 'inst' not described in 'vcn_v4_0_5_stop'
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c:1428: warning: Function parameter or
struct member 'inst' not described in 'vcn_v4_0_5_set_unified_ring_funcs'
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c:1594: warning: Function parameter or
struct member 'inst' not described in 'vcn_v4_0_5_set_irq_funcs'
Cc: Christian König<[email protected]>
Cc: Alex Deucher<[email protected]>
Signed-off-by: Srinivasan Shanmugam<[email protected]>
Reviewed-by: Boyuan Zhang <[email protected]>
<mailto:[email protected]>
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c
index 4e7da56a9f34..e487b68cecdd 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c
@@ -989,6 +989,7 @@ static int vcn_v4_0_5_start_dpg_mode(struct amdgpu_device
*adev, int inst_idx, b
* vcn_v4_0_5_start - VCN start
*
* @adev: amdgpu_device pointer
+ * @inst: VCN instance index to be started
*
* Start VCN block
*/
@@ -1198,6 +1199,7 @@ static void vcn_v4_0_5_stop_dpg_mode(struct amdgpu_device
*adev, int inst_idx)
* vcn_v4_0_5_stop - VCN stop
*
* @adev: amdgpu_device pointer
+ * @inst: VCN instance index to be stopped
*
* Stop VCN block
*/
@@ -1421,6 +1423,7 @@ static const struct amdgpu_ring_funcs
vcn_v4_0_5_unified_ring_vm_funcs = {
* vcn_v4_0_5_set_unified_ring_funcs - set unified ring functions
*
* @adev: amdgpu_device pointer
+ * @inst: instance of the VCN block for which to set the ring functions
*
* Set unified ring functions
*/
@@ -1587,6 +1590,7 @@ static const struct amdgpu_irq_src_funcs
vcn_v4_0_5_irq_funcs = {
* vcn_v4_0_5_set_irq_funcs - set VCN block interrupt irq functions
*
* @adev: amdgpu_device pointer
+ * @inst: instance of the VCN block for which to set the IRQ functions
*
* Set VCN block interrupt irq functions
*/
