[AMD Official Use Only - AMD Internal Distribution Only] Should also probably fix
rsetore -> restore as well Kent > -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of Alex > Deucher > Sent: Monday, September 9, 2024 1:56 PM > To: Zhang, Jesse(Jie) <[email protected]> > Cc: [email protected]; Deucher, Alexander > <[email protected]>; Koenig, Christian > <[email protected]>; Huang, Tim <[email protected]> > Subject: Re: [PATCH] drm/amdkfd: Fix resource leak in riu rsetore queue > > On Sun, Sep 8, 2024 at 9:20 PM [email protected] <[email protected]> > wrote: > > > > To avoid memory leaks, release q_extra_data when exiting the restore queue. > > v2: Correct the proto (Alex) > > should be criu, not riu. > > Alex > > > > > Signed-off-by: Jesse Zhang <[email protected]> > > --- > > drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > > index 20ea745729ee..b439d4d0bd84 100644 > > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > > @@ -1046,6 +1046,7 @@ int kfd_criu_restore_queue(struct kfd_process *p, > > pr_debug("Queue id %d was restored successfully\n", > > queue_id); > > > > kfree(q_data); > > + kfree(q_extra_data); > > > > return ret; > > } > > -- > > 2.25.1 > >
