Re: [PATCH] drm/amdgpu: Do not init ta microcode from guest side

[Lazar, Lijo]

On 8/12/2024 8:52 AM, Hawking Zhang wrote:
> TA should not be loaded from guest side.

Does this apply to XGMI TA?

Thanks,
Lijo

> 
> Signed-off-by: Hawking Zhang <hawking.zh...@amd.com>
> Reviewed-by: Shiwu Zhang <shiwu.zh...@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c 
> b/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c
> index 85ec9e35690a..749d8143b1e7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v13_0.c
> @@ -132,9 +132,11 @@ static int psp_v13_0_init_microcode(struct psp_context 
> *psp)
>                   (adev->emu_flags & AMDGPU_EMU_dGPU_SIDEWINDER))
>                       break;
>               /* It's not necessary to load ras ta on Guest side */
> -             err = psp_init_ta_microcode(psp, ucode_prefix);
> -             if (err)
> -                     return err;
> +             if (!amdgpu_sriov_vf(adev)) {
> +                     err = psp_init_ta_microcode(psp, ucode_prefix);
> +                     if (err)
> +                             return err;
> +             }
>               break;
>       default:
>               BUG();