[Public] > -----Original Message----- > From: Wang, Yang(Kevin) <[email protected]> > Sent: Tuesday, April 30, 2024 12:14 PM > To: Huang, Tim <[email protected]>; [email protected] > Cc: Deucher, Alexander <[email protected]>; Koenig, Christian > <[email protected]> > Subject: RE: [PATCH] drm/amdgpu: fix uninitialized scalar variable warning > > [Public] > > -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of Huang, > Tim > Sent: Tuesday, April 30, 2024 11:32 AM > To: [email protected] > Cc: Deucher, Alexander <[email protected]>; Koenig, Christian > <[email protected]> > Subject: RE: [PATCH] drm/amdgpu: fix uninitialized scalar variable warning > > [Public] > > [Public] > > Ping ... > > -----Original Message----- > > From: Huang, Tim <[email protected]> > > Sent: Friday, April 26, 2024 9:14 AM > > To: [email protected] > > Cc: Deucher, Alexander <[email protected]>; Koenig, Christian > > <[email protected]>; Huang, Tim <[email protected]> > > Subject: [PATCH] drm/amdgpu: fix uninitialized scalar variable warning > > > > Clear warning that field bp is uninitialized when calling > > amdgpu_virt_ras_add_bps. > > > > Signed-off-by: Tim Huang <[email protected]> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > > index 54ab51a4ada7..a2f15edfe812 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > > @@ -395,6 +395,8 @@ static void amdgpu_virt_add_bad_page(struct > > amdgpu_device *adev, > > else > > vram_usage_va = adev->mman.drv_vram_usage_va; > > > > + memset(&bp, 0, sizeof(struct eeprom_table_record)); > [Kevin]: > > It is better to change code to "sizeof (bp)".
Yes, agree, will change to this. Thanks. Tim > > Reviewed-by: Yang Wang <[email protected]> > > Best Regards, > Kevin > > + > > if (bp_block_size) { > > bp_cnt = bp_block_size / sizeof(uint64_t); > > for (bp_idx = 0; bp_idx < bp_cnt; bp_idx++) { > > -- > > 2.39.2 >
