Hello Bagas, I'm sorry for that. I will send another mail of this patch with your recommendations.
Em ter., 26 de dez. de 2023 23:30, Bagas Sanjaya <[email protected]> escreveu: > On Tue, Dec 26, 2023 at 08:57:41PM -0300, Marcelo Mendes Spessoto Junior > wrote: > > Signed-off-by: Marcelo Mendes Spessoto Junior < > [email protected]> > > > > The file display/modules/inc/mod_freesync.h has two identical AMD > > Copyright texts. This simple patch aims to remove the duplicate one. > > Hi Marcelo, > > The patch subject should have a subsystem prefix (e.g. the full subject > should have been "[PATCH] drm/amdgpu: mod_freesync: Remove duplicate > copyright boilerplate"). > > For patch description, I'd like to write it as "mod_freesync header file > has duplicated copyright boilerplate. Drop the duplicate". And make > sure that your Signed-off-by: trailer is on the bottom of description, > before triple dashes (`git commit -s` does it for you). > > > > > --- > > .../amd/display/modules/inc/mod_freesync.h | 28 ------------------- > > 1 file changed, 28 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/modules/inc/mod_freesync.h > b/drivers/gpu/drm/amd/display/modules/inc/mod_freesync.h > > index afe1f6cce..cc3dc9b58 100644 > > --- a/drivers/gpu/drm/amd/display/modules/inc/mod_freesync.h > > +++ b/drivers/gpu/drm/amd/display/modules/inc/mod_freesync.h > > @@ -1,31 +1,3 @@ > > -/* > > - * Copyright 2016 Advanced Micro Devices, Inc. > > - * > > - * Permission is hereby granted, free of charge, to any person > obtaining a > > - * copy of this software and associated documentation files (the > "Software"), > > - * to deal in the Software without restriction, including without > limitation > > - * the rights to use, copy, modify, merge, publish, distribute, > sublicense, > > - * and/or sell copies of the Software, and to permit persons to whom the > > - * Software is furnished to do so, subject to the following conditions: > > - * > > - * The above copyright notice and this permission notice shall be > included in > > - * all copies or substantial portions of the Software. > > - * > > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > EXPRESS OR > > - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > MERCHANTABILITY, > > - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT > SHALL > > - * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, > DAMAGES OR > > - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > > - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > > - * OTHER DEALINGS IN THE SOFTWARE. > > - * > > - * Authors: AMD > > - * > > - */ > > - > > - > > - > > - > > /* > > * Copyright 2016 Advanced Micro Devices, Inc. > > * > > The diff itself LGTM. > > Thanks. > > -- > An old man doll... just what I always wanted! - Clara >
