Deucher, Alexander wrote on 03.04.2017 17:43: >> -----Original Message----- >> From: amd-gfx [mailto:[email protected]] On Behalf >> Of Kai Wasserbäch >> Sent: Monday, April 03, 2017 11:20 AM >> To: Wentland, Harry; amd-gfx list >> Subject: Re: [PATCH v2] drm/amdgpu: Read vram width from integrated >> system info table >> >> [...] >> >> I might miss something subtle here, but after reading this a couple of times, >> I've convinced myself this is exactly the same switch statement as in >> gmc_v7_0_mc_init() above, right? If so: why not move that part to common >> code as >> well? > > The register offsets and bitfields may change across different IP revisions. > The actual switch statement itself could be common I guess (minus the > registers), but I'm not sure if it's worth the effort.
Thanks to both of you for the explanation. Since everything was named exactly the same I assumed the definitions for the registers matched as well. Still if large chunks of code are common helpers might still be nice and reduce the overall LOCs. Anyway, that's obviously your decision. Cheers, Kai
signature.asc
Description: OpenPGP digital signature
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
