Am 04.01.2017 um 12:34 schrieb Yu, Xiangliang:
-----Original Message-----
From: Christian König [mailto:[email protected]]
Sent: Wednesday, January 04, 2017 6:27 PM
To: Yu, Xiangliang <[email protected]>; Zhou, David(ChunMing)
<[email protected]>; [email protected]
Cc: Liu, Monk <[email protected]>
Subject: Re: [V2 1/1] drm/amdgpu/gfx8: add support kernel interface
queue(KIQ)

Am 28.12.2016 um 03:59 schrieb Yu, Xiangliang:
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On
Behalf Of zhoucm1
Sent: Wednesday, December 28, 2016 10:32 AM
To: Yu, Xiangliang <[email protected]>; amd-
[email protected]
Cc: Liu, Monk <[email protected]>
Subject: Re: [V2 1/1] drm/amdgpu/gfx8: add support kernel interface
queue(KIQ)



On 2016年12月28日 10:27, Yu, Xiangliang wrote:
+
+       amdgpu_bo_kunmap(kiq->eop_obj);
+
I see it is in many places, which is don't need I think,
amdgpu_bo_free_kernel will handle it if I'm correct.
Memory kmap should be free ASAP from memory management point.
No, that is completely unnecessary as long as you don't run a 32bit system
with tight address space.
We can't decide what OS to use.  I agree with monk's comment that better to 
unmap it if cpu don't use.

No it isn't. As I said this is only necessary on 32bit systems with tight address space. In other words we simply don't really support that configuration any more.

If you don't need it then why do you want to kmap it in the first place?

Regards,
Christian.



Regards,
David zhou
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to