I'm not sure gfx PG works properly with some of the kfd features. I know there were problems in the past. We probably need to add some sort of handshake for when we have kfd running in order to disable gfx PG when necessary.
Alex From: amd-gfx [mailto:[email protected]] On Behalf Of StDenis, Tom Sent: Monday, August 08, 2016 1:59 PM To: Kuehling, Felix; [email protected] Subject: Re: [PATCH 09/14] drm/amd/amdgpu: Enable carrizo GFX PG Hi Felix, Hmm, it's unfortunate because I haven't been able to reproduce any hangs on my AM4 based Carrizo. What specific tests are you running when it hangs? Cheers, Tom ________________________________ From: Kuehling, Felix Sent: Monday, August 8, 2016 13:57 To: [email protected]<mailto:[email protected]>; StDenis, Tom Subject: Re: [PATCH 09/14] drm/amd/amdgpu: Enable carrizo GFX PG We're reverting this commit on the KFD branch because it's causing hangs on a bunch of HSA compute tests on CZ. Regards, Felix On 16-07-28 10:19 AM, Tom St Denis wrote: > Signed-off-by: Tom St Denis <[email protected]<mailto:[email protected]>> > --- > drivers/gpu/drm/amd/amdgpu/vi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c > index 9ba64989f092..4fa9fea541a5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -1578,7 +1578,13 @@ static int vi_common_early_init(void *handle) > AMD_CG_SUPPORT_HDP_LS | > AMD_CG_SUPPORT_SDMA_MGCG | > AMD_CG_SUPPORT_SDMA_LS; > + /* rev0 hardware requires workarounds to support PG */ > adev->pg_flags = 0; > + if (adev->rev_id != 0x00) { > + adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG | > + AMD_PG_SUPPORT_GFX_SMG | > + AMD_PG_SUPPORT_GFX_PIPELINE; > + } > adev->external_rev_id = adev->rev_id + 0x1; > break; > case CHIP_STONEY:
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
