vmatare updated this revision to Diff 78425. vmatare marked an inline comment as done. vmatare added a comment.
Another attempt at a simple solution that works with all versions of MariaDB and MySQL. This one comes with the added cost of including the full `mysql.h` because that seems to be the only consistently supplied drop-in header by MariaDB. Other solutions would involve additional CMake hackery to distinguish between MariaDB and MySQL, but for the sake of sanity, let's sacrifice compilation time for simplicity here. Please test again, and thanks a lot for the review so far. REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28165?vs=78424&id=78425 REVISION DETAIL https://phabricator.kde.org/D28165 AFFECTED FILES src/core-impl/storage/sql/mysql-shared/MySqlStorage.h tests/core-impl/collections/CMakeLists.txt To: vmatare Cc: jfowkes, asturmlechner, wbauer, amarok-devel, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill, jackyalcine, nhuisman, paul, domson, yaohanchen, malteveerman, markey, James, tbettler, Smar, ricktimmis, schweingruber, heikobecker
