malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision.
REVISION SUMMARY This includes the C++ implementation of the lyrics functionality, which is now async. Also includes a fix for SqlAlbumTest, which failed since my last stuttering revision. The biggest change though is in CollectionTreeItemModelBase. It now loads an album's tracks in a Threadweaver job and CollectionSortFilterProxyModel filters unloaded albums. This makes the CollectionTreeView seem to grow when expanding an artist with many albums like "Various Artists" instead of freezing for a while depending on your collection size. The CollectionTreeView must be set to display album years for this to take effect. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11968 AFFECTED FILES src/CMakeLists.txt src/browsers/CollectionSortFilterProxyModel.cpp src/browsers/CollectionSortFilterProxyModel.h src/browsers/CollectionTreeItemModelBase.cpp src/browsers/CollectionTreeItemModelBase.h src/context/LyricsManager.cpp src/context/LyricsManager.h src/context/applets/lyrics/plugin/LyricsEngine.cpp src/context/applets/lyrics/plugin/LyricsEngine.h src/core-impl/collections/db/sql/SqlMeta.cpp src/core-impl/collections/db/sql/SqlMeta.h src/covermanager/CoverFetchQueue.cpp src/covermanager/CoverFetchQueue.h src/covermanager/CoverFetcher.cpp src/covermanager/CoverFetcher.h src/dialogs/TagDialog.cpp src/dialogs/TagDialog.h src/lyrics/LyricsManager.cpp src/lyrics/LyricsManager.h src/scripting/scriptengine/AmarokLyricsScript.cpp src/scripting/scriptengine/AmarokLyricsScript.h src/scripting/scriptmanager/ScriptItem.cpp src/scripting/scripts/CMakeLists.txt src/scripting/scripts/lyrics_lyricwiki/CMakeLists.txt src/scripting/scripts/lyrics_lyricwiki/main.js src/scripting/scripts/lyrics_lyricwiki/script.desktop src/widgets/PrettyTreeRoles.h To: malteveerman, #amarok Cc: #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker
