----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122797/#review76967 -----------------------------------------------------------
Ship it! Looks good to me. Shipt it, but before please fix that the credentials are not saved when the user clicks no. src/services/gpodder/GpodderServiceConfig.cpp <https://git.reviewboard.kde.org/r/122797/#comment52950> This slot is called when the user clicks on no in the dialog asking if the credentials should be stored in plaintext. This means that the credentials shouldn't be saved when this slot is called. - Stefan Derkits On March 3, 2015, 9:14 p.m., Giuseppe Silletti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122797/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 9:14 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > Before to fix this bug, the gpodder plugin had problems with saving username > and password in plain text. > > There were two problems: > > 1) A useless space for the variable m_ignoreWallet was saved in the config > file > 2) The saving of the credential in plain text where made in the wrong way. > Now it is called the function askAboutMissingKWallet(), that make the use see > a dialog windows where is asked to save the credential in plain text. > Credential are now saved in the textDialogYes slot. > > > Diffs > ----- > > src/services/gpodder/GpodderServiceConfig.cpp 9098d59 > > Diff: https://git.reviewboard.kde.org/r/122797/diff/ > > > Testing > ------- > > It simply works now > > > Thanks, > > Giuseppe Silletti > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
