----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119412/#review62919 -----------------------------------------------------------
Ship it! This restores the sane beahviour (the insane one was apparently introduced by accident), so thanks for it and ship it! (I haven't tested it, the the diff looks completely fine) - Matěj Laitl On July 22, 2014, 8:20 p.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119412/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 8:20 p.m.) > > > Review request for Amarok and Anmol Ahuja. > > > Repository: amarok > > > Description > ------- > > 1. Touching the installation directory at configuration time is very > wrong, and usually fails, particularly when Amarok is being packaged, > since the source code tends to be built as a user and installed into > a chroot. > In this case, the script's call to os.makedirs() would normally fail. > > 2. Invoking "python" without looking for it first and without > considering that it might be called differently is also very wrong. > > We now properly look for the Python binary, only call PHAACG2.py if it > is found, store all the generated files inside ${CMAKE_BINARY_DIR} and > install them like any other file with install(). > > > Diffs > ----- > > CMakeLists.txt 1b03bda0e6769b5d8394ddab2fa39682089fc10c > src/CMakeLists.txt d3c74d09dce0eb03e6b67c7430515d0f9cd44f84 > > Diff: https://git.reviewboard.kde.org/r/119412/diff/ > > > Testing > ------- > > * The script finally stops failing to run if I configure Amarok as a user > without changing `CMAKE_INSTALL_PREFIX` (ie. it doesn't try writing to > `/usr/local` anymore). > * `AutoComplete.txt` is properly installed after everything is built, and > nothing outside `CMAKE_BINARY_DIR` is touched before installation time. > > > Thanks, > > Raphael Kubo da Costa > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
