----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115122/#review54237 -----------------------------------------------------------
I have tested your patch. It fixes the bug. However you seem to have done some extra work. After you fix these your patch should be good to go; after being reviewed by a core developer :) ChangeLog <https://git.reviewboard.kde.org/r/115122/#comment37928> We don't add minor Bugfixes to this list. Best to remove it src/toolbar/MainToolbar.cpp <https://git.reviewboard.kde.org/r/115122/#comment37930> nitpick: we added a space after '//' src/widgets/ProgressWidget.cpp <https://git.reviewboard.kde.org/r/115122/#comment37931> This change is damaging. It is not required. I have tested it with this code intact and the bug is still fixed. Revert. - Vedant Agarwala On Jan. 19, 2014, 1:07 p.m., Abhay Sombanshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115122/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2014, 1:07 p.m.) > > > Review request for Amarok. > > > Bugs: 299883 > https://bugs.kde.org/show_bug.cgi?id=299883 > > > Repository: amarok > > > Description > ------- > > Now , toolbar shows correct progress slider position and timelabel values > after restoring amarok from system tray. > > > Diffs > ----- > > ChangeLog 0eb03c8 > src/toolbar/MainToolbar.cpp 47f8ae5 > src/widgets/ProgressWidget.cpp 5b6702b > > Diff: https://git.reviewboard.kde.org/r/115122/diff/ > > > Testing > ------- > > * works as expected. > > > Thanks, > > Abhay Sombanshi > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
