> On Dec. 7, 2013, 6:43 p.m., Matěj Laitl wrote: > > Good to go from me, given all the circumstances.
Please add following tags to the commit message when comitting, also please add a line into Changelog: CCBUG: 305264 FUXED-IN: 2.9 - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114282/#review45312 ----------------------------------------------------------- On Dec. 7, 2013, 6:06 p.m., Yuri Chornoivan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114282/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2013, 6:06 p.m.) > > > Review request for Amarok. > > > Bugs: 305264 > https://bugs.kde.org/show_bug.cgi?id=305264 > > > Repository: amarok > > > Description > ------- > > Scripty can effectively help to translate .desktop files, so this patch tries > to trick scripty. The target translated files still installed as .spec by > renaming during installation. > > > Diffs > ----- > > src/scripts/librivox_service/CMakeLists.txt f4ef2da > src/scripts/librivox_service/script.desktop PRE-CREATION > src/scripts/librivox_service/script.spec 26719d5 > src/scripts/lyrics_lyricwiki/CMakeLists.txt aa25589 > src/scripts/lyrics_lyricwiki/script.desktop PRE-CREATION > src/scripts/lyrics_lyricwiki/script.spec d3346dc > src/scripts/radio_station_service/CMakeLists.txt d053697 > src/scripts/radio_station_service/script.desktop PRE-CREATION > src/scripts/radio_station_service/script.spec 9e7fb0e > src/scripts/script_console/CMakeLists.txt 4d31f7c > src/scripts/script_console/script.desktop PRE-CREATION > src/scripts/script_console/script.spec 7d0a59d > > Diff: http://git.reviewboard.kde.org/r/114282/diff/ > > > Testing > ------- > > Compiles, installs, can be translated through KDE translation system. > > > Thanks, > > Yuri Chornoivan > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
