----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113389/#review43919 -----------------------------------------------------------
Yes please, get rid of multi lyrics altogether, they are too niche and complex. In future, we might extend MetaFile::Track, SqlTrack etc. to actually show the read lyrics, but that doesn't have to be a part of this patch. - Matěj Laitl On Nov. 18, 2013, 2:50 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113389/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 2:50 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > Changes made to the tagging framework in shared/. > > > Diffs > ----- > > shared/MetaValues.h 4b003ed > shared/tag_helpers/APETagHelper.cpp ba39a10 > shared/tag_helpers/ASFTagHelper.cpp 3439845 > shared/tag_helpers/ID3v2TagHelper.h a9c9ab9 > shared/tag_helpers/ID3v2TagHelper.cpp 03a3836 > shared/tag_helpers/MP4TagHelper.cpp 23d8879 > shared/tag_helpers/VorbisCommentTagHelper.cpp 8ff52c5 > > Diff: http://git.reviewboard.kde.org/r/113389/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
