> On Nov. 5, 2013, 11:48 p.m., Matěj Laitl wrote: > > I'm starring at Diff v2 and either: > > 1. I'm a fool > > 2. ReviewBoard fools me (actually rather probable) > > 3. You uploaded a diff between old part 1 and new part 1, not the complete > > new part 1. > > > > I'm sorry it took too long for me just to realize this.
Oh, the 3rd scenario is definitely what happened. I'm uploading the diffs manually (I can't figure out how to split review using rb-tools), and I just assumed that diff between previous revision and the next one is what it wants from me. I actually didn't realize anything either, and I looked through the review after uploading. - Konrad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113272/#review43128 ----------------------------------------------------------- On Nov. 6, 2013, 7:19 p.m., Konrad Zemek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113272/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 7:19 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > These are changes in the StatSyncing framework that I made as a part of my > project. > > > Diffs > ----- > > src/statsyncing/Config.h 140e647 > src/statsyncing/Config.cpp dd82dbe > src/statsyncing/Controller.h 10c72a8 > src/statsyncing/Controller.cpp bf4c5d8 > src/statsyncing/Provider.h d9663f9 > src/statsyncing/Provider.cpp 775fce3 > src/statsyncing/ProviderFactory.h PRE-CREATION > src/statsyncing/ProviderFactory.cpp PRE-CREATION > src/statsyncing/SimpleTrack.h PRE-CREATION > src/statsyncing/SimpleTrack.cpp PRE-CREATION > src/statsyncing/SimpleWritableTrack.h PRE-CREATION > src/statsyncing/SimpleWritableTrack.cpp PRE-CREATION > src/statsyncing/Track.h 2f91704 > src/statsyncing/Track.cpp 9655cc1 > src/statsyncing/TrackTuple.h 157d604 > src/statsyncing/TrackTuple.cpp 9442794 > src/statsyncing/jobs/SynchronizeTracksJob.cpp b789aa3 > src/statsyncing/ui/ConfigureProviderDialog.h PRE-CREATION > src/statsyncing/ui/ConfigureProviderDialog.cpp PRE-CREATION > src/statsyncing/ui/CreateProviderDialog.h PRE-CREATION > src/statsyncing/ui/CreateProviderDialog.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113272/diff/ > > > Testing > ------- > > > Thanks, > > Konrad Zemek > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
