-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112148/
-----------------------------------------------------------
(Updated Aug. 22, 2013, 7:06 p.m.)
Status
------
This change has been marked as submitted.
Review request for Amarok.
Description
-------
Prefer QChar overloads over the QString ones for efficiency
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
7. Check single-char QString operations for efficiency
[doublequote_chars]...OOPS! 60 issues found!
[...]
Diffs
-----
shared/TagsFromFileNameGuesser.cpp f2ec2ba
src/EngineController.cpp 70afbb2
src/amarokurls/ContextUrlRunner.cpp 05719ed
src/browsers/filebrowser/FileBrowser.cpp 82dad74
src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp e631de2
src/context/applets/labels/LabelsApplet.cpp a3f80fb
src/context/applets/tabs/TabsView.cpp fc11c4a
src/context/engines/lyrics/LyricsEngine.cpp a65be19
src/core-impl/collections/db/sql/SqlCollection.cpp c420e35
src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 1e20535
src/core-impl/collections/db/sql/SqlMeta.cpp fd464cb
src/core-impl/collections/db/sql/SqlRegistry_p.cpp 21b9d45
src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp 2cdd10a
src/core-impl/collections/upnpcollection/UpnpCache.cpp 21f8264
src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp ead5d79
src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 73192a8
src/core/podcasts/PodcastImageFetcher.cpp afd4929
src/dialogs/TagGuesser.cpp deb403f
src/dynamic/DynamicModel.cpp 201cc93
src/musicbrainz/MusicBrainzFinder.cpp 6892232
src/network/NetworkAccessManagerProxy.cpp a2694bf
src/playlist/PlaylistModel.cpp e93bd06
src/playlist/PlaylistSortWidget.cpp bc25b1b
src/playlist/proxymodels/ProxyBase.cpp 47d36f4
src/playlistgenerator/constraints/TagMatch.cpp d53ca53
src/services/jamendo/JamendoDatabaseHandler.cpp 1e7dc2d
src/services/lastfm/biases/WeeklyTopBias.cpp c99c538
src/widgets/MetaQueryWidget.cpp 7ae9373
src/widgets/ProgressWidget.cpp 82ff9bf
tests/TestDebug.cpp c9ff0bb
tests/TestTrackOrganizer.cpp ffcec68
tests/browsers/TestSingleCollectionTreeItemModel.cpp dbd3ada
tests/context/engines/TestDataEngineBlackBox.cpp a9b83e9
tests/core-impl/collections/db/sql/TestSqlCollectionLocation.cpp c4522c8
tests/core-impl/collections/db/sql/TestSqlScanManager.cpp 16c29ca
tests/synchronization/TestMasterSlaveSynchronizationJob.cpp 8d1ea51
tests/synchronization/TestUnionJob.cpp 86f4159
utilities/amzdownloader/AmzDownloader.cpp 54106f2
Diff: http://git.reviewboard.kde.org/r/112148/diff/
Testing
-------
Thanks,
Frank Meerkoetter
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
