----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110036/#review35437 -----------------------------------------------------------
test, ignore - Mark Kretschmann On April 18, 2013, 8:03 a.m., Ryan McCoskrie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110036/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 8:03 a.m.) > > > Review request for Amarok. > > > Description > ------- > > A new, unambitious attempt at adding equalizer functions to the scripting > interface. > > Adds to EngineController the functions: > * QString eqPreset() > * void eqApplyPreset(QString name) > And the signal: > eqPresetApplied(QString name) > > Adds to AmarokEngineScript the same functions > set up as a property. > > > Diffs > ----- > > src/EngineController.cpp 28fb256 > src/scriptengine/AmarokEngineScript.h f1cdb8c > src/scriptengine/AmarokEngineScript.cpp 4d52bbe > src/EngineController.h 5de4beb > > Diff: http://git.reviewboard.kde.org/r/110036/diff/ > > > Testing > ------- > > Quick check using the script console that presets can be changed. > The preset does get applied but it won't show in the EqualizerDialog. > Possible other bugs. > > > Thanks, > > Ryan McCoskrie > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
