> On June 28, 2013, 6:59 p.m., Mark Kretschmann wrote: > > Nice patch! I recall we used to have this feature in an earlier Amarok > > version, but it got lost at some point :) > > > > Do you have push rights for kde git, or should we push it for you? > > fleissig fleissig wrote: > I don't have rights, you should push it. > > Mark Kretschmann wrote: > Do you want "fleissig fleissig" as your name in the ChangeLog, or do you > prefer another name?
I'd even go further, we do really want to have contributions under the real names, be it for proper attribution or copyright matters. - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111275/#review35242 ----------------------------------------------------------- On June 28, 2013, 10:57 p.m., fleissig fleissig wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111275/ > ----------------------------------------------------------- > > (Updated June 28, 2013, 10:57 p.m.) > > > Review request for Amarok. > > > Description > ------- > > putting Artist - Title of the current track to the clipboard using a shortcut > > > This addresses bug 228872. > https://bugs.kde.org/show_bug.cgi?id=228872 > > > Diffs > ----- > > src/MainWindow.h b2ee08014c110d1979176fe9d4abfad5076c1179 > src/MainWindow.cpp af47db7226244cc81f1a4f50000d3c980d758b93 > > Diff: http://git.reviewboard.kde.org/r/111275/diff/ > > > Testing > ------- > > > Thanks, > > fleissig fleissig > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
