----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110082/ -----------------------------------------------------------
(Updated May 4, 2013, 4:18 p.m.) Review request for Amarok. Changes ------- Fixes the pending issue Description ------- As agreed on the review for https://git.reviewboard.kde.org/r/104048/ , Qt::TooltipRole has been updated so that now the tooltip displays full name of the playlist. Occurrences of "description" have been removed (from the Playlist base class as well as the subclasses). This addresses bug 275821. https://bugs.kde.org/show_bug.cgi?id=275821 Diffs (updated) ----- src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 6ee3db3 src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.h 9b94872 src/core-impl/collections/mediadevicecollection/playlist/MediaDevicePlaylist.cpp 3510481 src/core-impl/playlists/types/file/PlaylistFile.h de71057 src/core-impl/playlists/types/file/PlaylistFile.cpp 073e140 src/core/playlists/Playlist.h 9fa854f src/playlistmanager/SyncedPlaylist.h 214bb5c src/playlistmanager/SyncedPlaylist.cpp ae6f9ab src/playlistmanager/sql/SqlPlaylist.h d28d161 src/playlistmanager/sql/SqlPlaylist.cpp 2d6ef61 src/playlistmanager/sql/SqlPlaylistGroup.cpp 2862034 src/playlistmanager/sql/SqlUserPlaylistProvider.h 2ff9fda src/playlistmanager/sql/SqlUserPlaylistProvider.cpp 0ffb3d6 Diff: http://git.reviewboard.kde.org/r/110082/diff/ Testing ------- Testing done. Works. Builds successfully and passes the tests. File Attachments ---------------- displays the new tooltip http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot1.png displays the new tooltip http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/amarok_screenshot.png Thanks, Vedant Agarwala
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
