> On April 29, 2013, 9:57 a.m., Edward Hades Toroshchin wrote: > > src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp, > > line 67 > > <http://git.reviewboard.kde.org/r/110187/diff/1/?file=141032#file141032line67> > > > > This can only end well. > > > > I would rather avoid magic numbers, and construct the pointer array > > dynamically, say QVector<char*> or similar. > > > > Mat?j, what do you think?
OMG, silly reviewboard differentiates between comment on review and review of the same line. >:-| Please see below for reply. - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/#review31732 ----------------------------------------------------------- On April 25, 2013, 2:36 p.m., Patrick von Reth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110187/ > ----------------------------------------------------------- > > (Updated April 25, 2013, 2:36 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Don't communicate with mysql by env vars and autogenerated files > > Instead of generating the my.cnf every time amarok starts and to pass > the location of this file by setting an environment variable directly > pass the settings as arguments to mysql. As this is probably a better > approach and the only one working on windows. > > This fixes an issue where amarok is writing the database to "C:\Program Files > (x86)\Amarok\data\amarok". > This issue prevents Amarok from running correctly, because regarding to the > rights of the useraccount the directory can be not writeable. > > The commands used are taken from the output of "mysqld --verbose --help". > > > Diffs > ----- > > src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp > 0233498fdeb18ab51e709e9a78384fc37c47cb2a > > Diff: http://git.reviewboard.kde.org/r/110187/diff/ > > > Testing > ------- > > Only on windows > > > Thanks, > > Patrick von Reth > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
