Hi dear developers, Looking at EBN, I found a few fixes that should be easy to do in your morning routine:
Check for cpp macros and usage [cpp]...OOPS! 17 issues found! (those macros should be in cmake isntead): * src/services/ampache/AmpacheService.cpp: Unknown HAVE_FOO macro line# 32[[HAVE_LIBLASTFM]],101[[HAVE_LIBLASTFM]] (2) * src/dialogs/MusicBrainzTagger.cpp: Unknown HAVE_FOO macro line# 50[[HAVE_LIBOFA]],83[[HAVE_LIBOFA]],108[[HAVE_LIBOFA]],129[[HAVE_LIBOFA]],139[[HAVE_LIBOFA]] (5) * src/dialogs/MusicBrainzTagger.h: Unknown HAVE_FOO macro line# 27[[HAVE_LIBOFA]],57[[HAVE_LIBOFA]],70[[HAVE_LIBOFA]] (3) * src/widgets/AnalyzerWidget.cpp: Unknown HAVE_FOO macro line# 67[[HAVE_LIBVISUAL]] (1) * src/playlist/layouts/LayoutEditDialog.cpp: Unknown HAVE_FOO macro line# 105[[HAVE_WIDTH_MODES]],126[[HAVE_METRICS]] (2) * src/core-impl/meta/file/File.cpp: Unknown HAVE_FOO macro line# 46[[HAVE_LIBLASTFM]],496[[HAVE_LIBLASTFM]],530[[HAVE_LIBLASTFM]] (3) * src/core/support/Debug.h: O/S or Compiler specific macro line# 79[[_WIN32]] (1) Check validity of i18n calls [i18ncheckarg]...OOPS! 4 issues found! * src/widgets/FilenameLayoutWidget.cpp: wrong argument count, have 1 need 0 line# 93 (1) * src/playlistgenerator/constraints/Checkpoint.cpp: wrong argument count, have 0 need 1 line# 170 (1) * src/playlistgenerator/constraints/TagMatch.cpp: wrong argument count, have 0 need 1 line# 183 (1) * src/playlistgenerator/constraints/TagMatch.cpp: wrong argument count, have 0 need 4 line# 169 (1) Check for system calls to replace by KDE or Qt equivalents [syscalls]...OOPS! 3 issues found! (Some system calls are not portable, please use the suggested portable wrapper instead. See kde_file.h): * src/main.cpp: line# 319[signal[KDE_signal]],320[signal[KDE_signal]] (2) * src/playlistmanager/PlaylistManager.cpp: line# 326[rename[KDE_rename]] (1) Validates KConfigXT files using 'xmllint' [validate]...OOPS! 2 issues found! (make sure your .kcfg files conform to the KConfigXT schema): * src/amarokconfig.kcfg: parser error , Entity 'ldquo' not defined line# 357 (1) * src/amarokconfig.kcfg: parser error , Entity 'rdquo' not defined line# 357 (1) Have fun :) Regards, Myriam -- Proud member of the Amarok and KDE Community Protect your freedom and join the Fellowship of FSFE: http://www.fsfe.org Please don't send me proprietary file formats, use ISO standard ODF instead (ISO/IEC 26300) _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
