----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109781/ -----------------------------------------------------------
(Updated April 1, 2013, 8:16 p.m.) Review request for Amarok. Changes ------- Added changelog entry Summary (updated) ----------------- Bug #312407 - don't transcode from mp3 to mp3 Description ------- Added 3 checkbox in the TranscodingAssistantDialog: "Transcode all tracks" - transcode all tracks, the current default behavior "Ignore files which're already the selected format" - transcode only if source and setination file formats are different "Transcode only when needed for playability" - transcode only when needed for playability in the destination collection Diffs (updated) ----- ChangeLog 8db61e8 src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 11fa33e src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp 8a40c6c src/core-impl/collections/umscollection/UmsCollectionLocation.cpp e0ba0ac src/core/transcoding/TranscodingConfiguration.h 98b2bb8 src/core/transcoding/TranscodingConfiguration.cpp f97a43d src/transcoding/TranscodingAssistantDialog.h 76287a7 src/transcoding/TranscodingAssistantDialog.cpp 6bba0ec src/transcoding/TranscodingAssistantDialog.ui 2505bd3 src/transcoding/TranscodingJob.h 6170c2a src/transcoding/TranscodingJob.cpp cab76a7 src/transcoding/TranscodingOptionsStackedWidget.h 9495d44 src/transcoding/TranscodingOptionsStackedWidget.cpp cf4f328 Diff: http://git.reviewboard.kde.org/r/109781/diff/ Testing ------- Works as expected All build tests passed Thanks, Anmol Ahuja
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
