----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109695/#review30040 -----------------------------------------------------------
This review has been submitted with commit b0c79900429e8987c018112f875e09e565126408 by Matěj Laitl on behalf of Anmol Ahuja to branch master. - Commit Hook On March 27, 2013, 6:21 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109695/ > ----------------------------------------------------------- > > (Updated March 27, 2013, 6:21 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Bug 241066 - JJ: Add Signals trackStop and amarokShutdown to Amarok scripting > interface > > Changes: > 1. Added a prepareToQuit() signal to amarokWindowScript > 2. Replaced kapp macro calls with App::instance() because quit() is not > virtual > > Note: > Signal trackFinished()[trackStop] already exists, so only added > prepareToQuit()[amarokShutdown] > > > Diffs > ----- > > src/scriptengine/AmarokScript.cpp 922e71d > src/dbus/mpris2/MediaPlayer2.cpp f86ccb3 > src/scriptengine/AmarokWindowScript.h 5407579 > src/dbus/mpris1/RootHandler.cpp e60eb1b > src/MainWindow.cpp 66f4f76 > ChangeLog 284f188 > src/App.cpp fdb4255 > src/scriptengine/AmarokWindowScript.cpp 897e2da > > Diff: http://git.reviewboard.kde.org/r/109695/diff/ > > > Testing > ------- > > Tested the new signal in a script > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
