----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109369/ -----------------------------------------------------------
Review request for Amarok. Description ------- 1. Made a levelSort() function to sort tracks according to multiple parameters ( Should i just be sorting tracks belonging to the same album? ) 2. Modified copyUrlToCollection() to use QList instead of QMap 3. FileView's files are being copied in the order of selection, thanks to using QLists ( is that acceptable? ) Diffs ----- src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp aa61072 src/core-impl/collections/db/sql/SqlCollectionLocation.cpp 93efe97 src/services/mp3tunes/Mp3tunesServiceCollectionLocation.h 2b06cb4 src/services/ServiceCollectionLocation.cpp d1cb0d8 src/core/collections/CollectionLocation.h d37ccfb src/core/collections/CollectionLocation.cpp aecc068 src/core-impl/collections/umscollection/UmsCollectionLocation.cpp e0ba0ac src/core-impl/collections/umscollection/UmsCollectionLocation.h 45ba596 src/core-impl/collections/umscollection/UmsCollection.cpp 6bebd98 src/core-impl/collections/support/TrashCollectionLocation.cpp 61c2e49 src/core-impl/collections/support/TrashCollectionLocation.h 239a977 src/core-impl/collections/support/PlaylistCollectionLocation.cpp c885046 src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp a8d9f52 src/core-impl/collections/support/PlaylistCollectionLocation.h 10a365f src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp c1b76f5 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h 821f1b0 src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp f60aff6 src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.h e40529f src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp 8a40c6c src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h 3c2d9f2 src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp f8105f9 src/core-impl/collections/ipodcollection/IpodCollectionLocation.h cc27e19 src/core-impl/collections/db/sql/SqlCollectionLocation.h 0bcf244 src/core-impl/collections/audiocd/AudioCdCollectionLocation.cpp be13551 src/browsers/filebrowser/FileView.h df8fbee src/browsers/CollectionTreeItemModel.cpp fa194b1 src/browsers/CollectionTreeView.cpp fd9fe66 src/browsers/collectionbrowser/CollectionWidget.h c281f41 Diff: http://git.reviewboard.kde.org/r/109369/diff/ Testing ------- Seems to be copying tracks in the correct order now Thanks, Anmol Ahuja
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
