On 26. 2. 2013 Ralf Engels wrote:
> Am Dienstag, 26. Februar 2013, 13:29:53 schrieb Matěj Laitl:
> > 1. The {category,collection,playlist provider} icons on the left seem to
> > be scaled to some non-predefined size, which makes them look blurry here.
> > After closer investigation it seems the icons are 28 pix while the natural
> > size would be 32 pix. The action icons (plug in USB Stick for
> > UmsCollection) seem to be upscaled too.
>
> The icon list icon size is default 28px.
> Only the toolbar icon size is 32px. I thought about using this size but it
> seemed to me to be on the side of a dirty hack.
> We were using a much to large icon size all along.
Actually not true, we were arbitrarily subtracting 4 px from the icon size.
See "PrettyTreeDelegate: more tweaks & cleanups" commit.
> > 3. In Playlists -> Saved Playlists, it lists playlist-related actions for
> > playlist providers "Amarok Database" and "Playlist Files on Disk". This
> > seems to be the problem of the model, not the delegate though. Clicking
> > the actions also has a "funny" effect, the model seems to collect & combine
> > actions from all child playlists. I will fix this unless you are faster.
>
> I haven't noticed that.
> Also I tried to provoke the small-icon actions for playlists to see if they
> are still working correctly but I couldn't.
Actually it is worse. To reproduce:
1. have a few playlists in both Amarok Database and in files with a few songs
2. right click on one of the playlists -> append to playlist
3. OMG a bazzilion of unrelated tracks is added to playlist!
So it seems that removing the static action hackery broke this.
Matěj
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
