> On Feb. 15, 2013, 10:13 a.m., Edward Hades Toroshchin wrote: > > Not judging if this is needed at all, I see the following problems: > > > > 1. This removes the "Left" and "Right" shortcuts, which users may have > > gotten used to. > > > > 2. Usually (in games and photo editing software, for example) the precision > > modifiers are like this: > > > > Ctrl-<key> — short seek (fine tuning) > > <key> — default medium seek > > Shift-<key> — long seek (fast scrolling, zooming, whatever). > > > > I believe we should follow this "convention".
+1 to all of the above. This raises the question whether the default value (10s) of the mofidier-less seek (medium) should be kept at 10s or raised a bit. - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108964/#review27503 ----------------------------------------------------------- On Feb. 14, 2013, 7:28 p.m., Anmol Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108964/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2013, 7:28 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Added 3 different seek options with customisable seek durations which can be > set in the playback-config: > Shift + Left/Right= Short Seek > Alt + Left/Right= Medium Seek > Control + Left/Right= Long Seek > > > Diffs > ----- > > src/EngineController.h e9a8c26 > src/EngineController.cpp 3577acf > src/MainWindow.cpp 8f985dc > src/amarokconfig.kcfg 3ebf71d > src/configdialog/dialogs/PlaybackConfig.ui 3a79e43 > > Diff: http://git.reviewboard.kde.org/r/108964/diff/ > > > Testing > ------- > > > Thanks, > > Anmol Ahuja > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
