----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106042/ -----------------------------------------------------------
(Updated Aug. 27, 2012, 5:50 p.m.) Review request for Amarok, Edward Hades Toroshchin, Vishesh Handa, and Matěj Laitl. Changes ------- The logger issue was fixed. The updation of the nepomuk collection is shown to the user. Description ------- Nepomuk plugin for Amarok. Almost all of the code changes can be found in src/core-impl/collections/nepomukcollection/* And a minor change in src/core-impl/collections/support/MemoryMeta.cpp Code builds and after Nepomuk plugin is activated in the "Settings" dialog, Nepomuk Plugin comes into play and queries all the tracks in your machine. The query is not 'that' fast and might take several seconds depending on the number of tracks in your box. IMPORTANT : Make sure Nepomuk is enabled if you want to give the plugin a spin. Diffs (updated) ----- src/core-impl/collections/CMakeLists.txt c78b920 src/core-impl/collections/nepomukcollection/CMakeLists.txt 7cfd4b0 src/core-impl/collections/nepomukcollection/NepomukAlbum.h 185c25a src/core-impl/collections/nepomukcollection/NepomukAlbum.cpp 6a09a1b src/core-impl/collections/nepomukcollection/NepomukArtist.h 6fcedf3 src/core-impl/collections/nepomukcollection/NepomukArtist.cpp 13ddf01 src/core-impl/collections/nepomukcollection/NepomukCollection.h 928b145 src/core-impl/collections/nepomukcollection/NepomukCollection.cpp cb185e8 src/core-impl/collections/nepomukcollection/NepomukCollectionFactory.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukCollectionFactory.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukComposer.h 1b11325 src/core-impl/collections/nepomukcollection/NepomukComposer.cpp f21251e src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.h PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukConstructMetaJob.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/NepomukGenre.h ce0e3b7 src/core-impl/collections/nepomukcollection/NepomukGenre.cpp 945074c src/core-impl/collections/nepomukcollection/NepomukQueryMaker.h 50067de src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp 33163ea src/core-impl/collections/nepomukcollection/NepomukRegistry.h a21347e src/core-impl/collections/nepomukcollection/NepomukRegistry.cpp 8afa199 src/core-impl/collections/nepomukcollection/NepomukTrack.h 77dd8c7 src/core-impl/collections/nepomukcollection/NepomukTrack.cpp 7db01cf src/core-impl/collections/nepomukcollection/NepomukYear.h 504cbe2 src/core-impl/collections/nepomukcollection/NepomukYear.cpp 1f13de0 src/core-impl/collections/nepomukcollection/amarok_collection-nepomukcollection.desktop 1ac9f02 src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.h PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukAlbum.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukArtist.h PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukArtist.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukComposer.h PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukComposer.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukGenre.h PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukGenre.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukLabel.h PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukLabel.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukTrack.h PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukTrack.cpp PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukYear.h PRE-CREATION src/core-impl/collections/nepomukcollection/meta/NepomukYear.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106042/diff/ Testing ------- Minimal. Plan to spend the remaining time on testing the plugin. Thanks, Phalgun Guduthur
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
