On 21. 8. 2012 Riccardo Iaconelli wrote:
> On Tuesday 21 August 2012 16:07:27 Matěj Laitl wrote:
> > Then I think a good compromise could be to merge qml branch into master as
> > soon as Level 0 is reasonably completed and with confidence that
> > completing Level 1 wouldn't block the release unacceptably long.
>
> Perfect, exactly what I meant.
Sounds like a plan, good!
> > b) The changes create a lot of dead code. We should try (yep, not just
> > you) to remove all the code made dead by CV QMLification. Do you see how
> > current info applet adapts to currently selected media sources view?
> > There's a lot of code associated spread across code-base and it seems that
> > it's going to be dead. (or do you plan to preserve some form of this
> > functionality? Sometimes it gives nice info, but it seems hard to present
> > it in a sensible (UI-wise) way)
>
> Most of the old code is going to be dead. I'm keeping it alive in the
> development branch because it's a very helpful guidance in restructuring the
> various dataengines (they're really, really tied to C++ and custom data
> types) and porting over some existing bits.
I see. One of the reasons I wanted to keep 2 branches, but I understand that
having 2 check-outs is less convenient than having the old code around.
Anyways, I've glad we've reached consensus. (if other devs are of similar
thinking)
Matěj
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
