----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105919/ -----------------------------------------------------------
Review request for Amarok, Bart Cerneels and Myriam Schweingruber. Description ------- StatSyncing: move configuration to standard Configure Amarok.. dialog ...to a newly created Metadata page. configdialog: split metadata options into separate category ...the Local Collection page was too crowded and I will add stats synchronization to Metadata page ConfigDialog: formatting StatSyncing: fix "Synchronizing Track Statistics" job progress bar StatSyncing: make Provider QSharedData ...and everywhere reference it using QExplicitlySharedDataPointer. This makes its memory management less error-prone. StatSyncing: introduce ScrobblingService, adapt Last.fm ScrobblerAdapter This makes StatSyncing::Controller handle scrobbling, too. Abstract Base Class ScrobblingService is introduced, lastfm ScrobblerAdapter is made a subclass of it. This means that it is now possible to plug multiple (different) scrobbling services, for example libre.fm in future. ScrobblerAdapter: set correct timestamp when scrobbling UmsCollection: More unique collectionId() useful for StatSyncing Diffs ----- src/CMakeLists.txt 8596144087709d9baab19b63c35f0c8169dca427 src/configdialog/ConfigDialog.cpp dec537ff4fa6dfd8ef7008cc0afb50269d5d0a9d src/configdialog/dialogs/MetadataConfig.h PRE-CREATION src/configdialog/dialogs/MetadataConfig.cpp PRE-CREATION src/configdialog/dialogs/MetadataConfig.ui PRE-CREATION src/core-impl/collections/umscollection/UmsCollection.h 3229436efaffd443959b0d820f9437636e5111a1 src/core-impl/collections/umscollection/UmsCollection.cpp fb326fcdfd474c7340a9f13f80e211b49a23b339 src/dialogs/CollectionSetup.h 23d717ac386f9d1893a00c75e0972c0c35adf2f9 src/dialogs/CollectionSetup.cpp cc3b756d9029c771b7da2cda74b6171dff45c9dc src/services/lastfm/LastFmService.h ac13d41cc5fd626a3ed6cb306d0969ef320c0c09 src/services/lastfm/LastFmService.cpp a14d989b3fac81e545df095adee36580b052fea7 src/services/lastfm/ScrobblerAdapter.h 613ad9973b0d768a0345acbe801a72e2652c9c90 src/services/lastfm/ScrobblerAdapter.cpp fa8635bb8c5492a2a434f6f947afa5f215124fee src/statsyncing/Config.h PRE-CREATION src/statsyncing/Config.cpp PRE-CREATION src/statsyncing/Controller.h PRE-CREATION src/statsyncing/Controller.cpp PRE-CREATION src/statsyncing/Options.h PRE-CREATION src/statsyncing/Process.h PRE-CREATION src/statsyncing/Process.cpp PRE-CREATION src/statsyncing/Provider.h PRE-CREATION src/statsyncing/Provider.cpp PRE-CREATION src/statsyncing/ScrobblingService.h PRE-CREATION src/statsyncing/ScrobblingService.cpp PRE-CREATION src/statsyncing/TrackTuple.h PRE-CREATION src/statsyncing/TrackTuple.cpp PRE-CREATION src/statsyncing/collection/CollectionProvider.h PRE-CREATION src/statsyncing/collection/CollectionProvider.cpp PRE-CREATION src/statsyncing/jobs/MatchTracksJob.h PRE-CREATION src/statsyncing/jobs/MatchTracksJob.cpp PRE-CREATION src/statsyncing/jobs/SynchronizeTracksJob.cpp PRE-CREATION src/statsyncing/models/MatchedTracksModel.h PRE-CREATION src/statsyncing/models/MatchedTracksModel.cpp PRE-CREATION src/statsyncing/models/ProvidersModel.h PRE-CREATION src/statsyncing/models/ProvidersModel.cpp PRE-CREATION src/statsyncing/ui/ChooseProvidersPage.h PRE-CREATION src/statsyncing/ui/ChooseProvidersPage.cpp PRE-CREATION src/statsyncing/ui/MatchedTracksPage.h PRE-CREATION src/statsyncing/ui/MatchedTracksPage.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105919/diff/ Testing ------- Thanks, Matěj Laitl
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
