----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105409/ -----------------------------------------------------------
Review request for Amarok, Bart Cerneels and Myriam Schweingruber. Description ------- StatSyncing: better sizeHint()s, UI fixes, clean-ups StatSyncing: paint rating beautifully using stars StatSyncing: implement auto-synchronize on startup and collection appearance Only collections previously checked and collections that are synchronized by default (Local and iPod collections currently) and not unchecked participate in automatic synchronization. StatSyncing: Implement saving of synchronized providers and fields plus reduce heuristics so that stats of UMSCollection can be tried too. StatSyncing: Back button in the matched tracks dialog plus cleanup some memory management etc. StatSyncing: GUI: add page for the first step of the synchronization * Providers can be chosen * Fields can be chosen * Additional info is displayed Revert Meta::Track::recentPlayCount() addition, use Capability instead RecentStatsCapability is introduced by this commit and implemented by IpodMeta, StatSyncing is adapted to it. Diffs ----- src/CMakeLists.txt 260e50bc208a81a963796048ada1856f0f8aaa08 src/core-impl/collections/ipodcollection/IpodMeta.h df6d70b70ee9464218705c9a3a1c54d339884ce1 src/core-impl/collections/ipodcollection/IpodMeta.cpp 6d6e63cc9cb3c4b3072119aae4e61266b461714d src/core-impl/collections/proxycollection/ProxyCollectionMeta.h e5d7266840ca244c884e1c397258e9d4d1a961de src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 091f5f6b484c8a8f66111d8a251c76f08ed2e632 src/core-impl/collections/support/MemoryMeta.h 6641e31743c1b0280a00d0090d64da0f7251739e src/core-impl/meta/proxy/MetaProxy.h 0579d08152792465c9b002fd66f625e7c4c18b2f src/core-impl/meta/proxy/MetaProxy.cpp 51299f827e11ccaace9c8ffb012780c1b7db30b6 src/core/CMakeLists.txt 8dc23587650c2e0ccdfc7b83a74fd69f1ac56b11 src/core/capabilities/Capability.h 8ec6d1630b7622b07cd2b613866b2125c6f91214 src/core/capabilities/RecentStatsCapability.h PRE-CREATION src/core/capabilities/RecentStatsCapability.cpp PRE-CREATION src/core/meta/Meta.h a35d67f8f082bdf17fe850c485291ff04ab8477a src/core/meta/Meta.cpp 5a175d54620d4e0b77bc8e836bf019bfc6a6577c src/statsyncing/Controller.h PRE-CREATION src/statsyncing/Controller.cpp PRE-CREATION src/statsyncing/Process.h PRE-CREATION src/statsyncing/Process.cpp PRE-CREATION src/statsyncing/Provider.h PRE-CREATION src/statsyncing/Provider.cpp PRE-CREATION src/statsyncing/TrackTuple.h PRE-CREATION src/statsyncing/TrackTuple.cpp PRE-CREATION src/statsyncing/collection/CollectionProvider.h PRE-CREATION src/statsyncing/collection/CollectionProvider.cpp PRE-CREATION src/statsyncing/collection/CollectionTrack.h PRE-CREATION src/statsyncing/collection/CollectionTrack.cpp PRE-CREATION src/statsyncing/jobs/MatchTracksJob.h PRE-CREATION src/statsyncing/jobs/MatchTracksJob.cpp PRE-CREATION src/statsyncing/jobs/SynchronizeTracksJob.h PRE-CREATION src/statsyncing/jobs/SynchronizeTracksJob.cpp PRE-CREATION src/statsyncing/models/CommonModel.h PRE-CREATION src/statsyncing/models/CommonModel.cpp PRE-CREATION src/statsyncing/models/MatchedTracksModel.h PRE-CREATION src/statsyncing/models/MatchedTracksModel.cpp PRE-CREATION src/statsyncing/models/ProvidersModel.h PRE-CREATION src/statsyncing/models/ProvidersModel.cpp PRE-CREATION src/statsyncing/models/SingleTracksModel.cpp PRE-CREATION src/statsyncing/ui/ChooseProvidersPage.h PRE-CREATION src/statsyncing/ui/ChooseProvidersPage.cpp PRE-CREATION src/statsyncing/ui/ChooseProvidersPage.ui PRE-CREATION src/statsyncing/ui/MatchedTracksPage.h PRE-CREATION src/statsyncing/ui/MatchedTracksPage.cpp PRE-CREATION src/statsyncing/ui/TrackDelegate.h PRE-CREATION src/statsyncing/ui/TrackDelegate.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105409/diff/ Testing ------- Everything works as described and documented AFAICS. Thanks, Matěj Laitl
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
