----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105408/#review15305 -----------------------------------------------------------
Ship it! Yes, indeed, thanks! Will commit this later today. - Matěj Laitl On July 2, 2012, 9:05 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105408/ > ----------------------------------------------------------- > > (Updated July 2, 2012, 9:05 a.m.) > > > Review request for Amarok. > > > Description > ------- > > If you use i18n() in stuff that gets called before the main KComponentData is > created bad stuff happens [1] (and you were getting a warning about it for > ages). This fixes it by using I18N_NOOP and then using i18n over it. > > [1] > http://comments.gmane.org/gmane.comp.kde.devel.internationalization-and-documentation/24240 > > > Diffs > ----- > > shared/FileType.cpp 3ec66de > > Diff: http://git.reviewboard.kde.org/r/105408/diff/ > > > Testing > ------- > > Stuff properly shows as translated now > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
