----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105280/ -----------------------------------------------------------
Review request for Amarok, Bart Cerneels and Myriam Schweingruber. Description ------- StatSyncing: mass conflict resolution using "Take Ratings From" button StatSyncing: proper capitalization StatSyncing: MatchedTracksPage remember which tuples are expanded StatSyncing: Status bar line in MatchedTracksPage StatSyncing: support for recent playcount for more accurate synchronization Meta::Track: add recentPlayCount() and implement is in relevant subclasses Recent playcount is needed for reliable statistics synchronization, but I know no devices other that iPods supporting it. So I'm not really sure whether adding it to Meta::Track is justifiable, but this is a start. Another option would be a custom Capability for this, let me know what you prefer. StatSyncing: disable "Updated" and "Conflicting" tracks item when there are none StatSyncing: factor MatchedTracksPage out of Process Process got too crowdy. StatSyncing: more convenient rating conflict detection ...don't detect conflicts for collections that cannot write ratings Diffs ----- src/CMakeLists.txt a54e2dcbea4ad415d2f5a25c6cd925bf7760b625 src/core-impl/collections/ipodcollection/IpodMeta.h 623bd054694a2ddaae939aafd790d2a59b9827c8 src/core-impl/collections/ipodcollection/IpodMeta.cpp 5f045e61dfb52a3a5b31fd0361ba69d80e6e9aff src/core-impl/collections/proxycollection/ProxyCollectionMeta.h e5d7266840ca244c884e1c397258e9d4d1a961de src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 8d4df176e4ada5b63e6ca9b57f142c76e1b1ce5b src/core-impl/collections/support/MemoryMeta.h 6641e31743c1b0280a00d0090d64da0f7251739e src/core-impl/meta/proxy/MetaProxy.h 0579d08152792465c9b002fd66f625e7c4c18b2f src/core-impl/meta/proxy/MetaProxy.cpp 51299f827e11ccaace9c8ffb012780c1b7db30b6 src/core/meta/Meta.h d028c4c0eef2e5decddd058dca813671ceb0e594 src/core/meta/Meta.cpp 5a175d54620d4e0b77bc8e836bf019bfc6a6577c src/statsyncing/Controller.cpp PRE-CREATION src/statsyncing/Process.h PRE-CREATION src/statsyncing/Process.cpp PRE-CREATION src/statsyncing/Track.h PRE-CREATION src/statsyncing/Track.cpp PRE-CREATION src/statsyncing/TrackTuple.h PRE-CREATION src/statsyncing/TrackTuple.cpp PRE-CREATION src/statsyncing/collection/CollectionTrack.h PRE-CREATION src/statsyncing/collection/CollectionTrack.cpp PRE-CREATION src/statsyncing/models/CommonModel.cpp PRE-CREATION src/statsyncing/models/MatchedTracksModel.h PRE-CREATION src/statsyncing/models/MatchedTracksModel.cpp PRE-CREATION src/statsyncing/ui/MatchedTracksPage.h PRE-CREATION src/statsyncing/ui/MatchedTracksPage.cpp PRE-CREATION src/statsyncing/ui/MatchedTracksPage.ui PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105280/diff/ Testing ------- Thanks, Matěj Laitl
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
