> On May 26, 2012, 4:05 p.m., Ralf Engels wrote: > > Still waiting for feedback....
Hi Ralf, sorry for not replying earlier. In any case, the bug in question ( https://bugs.kde.org/show_bug.cgi?id=267319 ) got resolved as a duplicate of https://bugs.kde.org/show_bug.cgi?id=290168 which was in turn resolved as WONTFIX , and I was told the approach taken by my patch was not guaranteed to always work (because a resource can change states back and forth before settling on a "play" state). I was next told that I should filter based on audio/* and video/* and then see if something that seems like sensible audio is getting emitted. I would prefer it if Phonon had a way to tell me that playing the media resource does in fact emit audio, which will make it less hacky. So I think this review request should be closed because it is not the right direction. Regards, -- Shlomi Fish - Shlomi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103694/#review14184 ----------------------------------------------------------- On Jan. 14, 2012, 2:20 p.m., Shlomi Fish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103694/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2012, 2:20 p.m.) > > > Review request for Amarok. > > > Description > ------- > > This is a patch to https://bugs.kde.org/show_bug.cgi?id=267319 , where Amarok > refuses to enqueue many media file types that are supported by the Phonon > backend. > > It fixes the problem on Amarok by instantiating a > Phonon::MediaObject object and trying to see if it can load the local file. It > comes with the following reservations: > > 1. With Phonon-VLC all files (including non-media ones) are accepted. This > appears to affect dragonplayer as well, and seems to be a > Phonon::MediaObject's > ->setCurrentSource() related bug. ( I'll report it later. ) > > 2. I didn't try to enqueue playlist files yet. > > 3. On my x86-64 Mageia Linux cauldron laptop, the phonon-gstreamer backend > often crashes Amarok. However, the same files also crash gst123. > > 4. I added some traces there to test something back when I was using > phonon-vlc > - they are no longer needed. > > Anyway, please look into it and see if you like the direction I'm taking. > > Regards, > > -- Shlomi Fish > > > Diffs > ----- > > src/EngineController.cpp 81f39b7 > > Diff: http://git.reviewboard.kde.org/r/103694/diff/ > > > Testing > ------- > > > Thanks, > > Shlomi Fish > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
