----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104369/#review11785 -----------------------------------------------------------
Code is clean and (probably) functional. Even though it's not supposed to be I would ship this. It also makes me feel that a conversion utility from SQL -> nepomuk would not be to difficult to do. - Bart Cerneels On March 22, 2012, 4:58 p.m., Phalgun Guduthur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104369/ > ----------------------------------------------------------- > > (Updated March 22, 2012, 4:58 p.m.) > > > Review request for Amarok and Teo Mrnjavac. > > > Description > ------- > > I have tried to demonstrate a basic read and write of Nepomuk index through > Amarok by altering how song ratings are stored. > > When applied, this patch stores any changed rating of a song into the Nepomuk > index and not the Sql backend. To test this, change the rating of any song > through Amarok and check the attributes of that song using Dolphin > (song->properties). The song rating would have changed accordingly. > > To demonstrate the read part, Each song's rating is fetched from the Nepomuk > index instead of the Sql backend. To test this, change the rating of any song > through Dolphin and the same would be reciprocated in Amarok. > > Please note, this is only for proof of concept. This is not intended to be > shipped. > The code changes I have made are only temporary. The actual project will have > Nepomuk classes and handlers to do the same task. > > > Diffs > ----- > > src/core-impl/collections/db/sql/CMakeLists.txt bdb3966 > src/core-impl/collections/db/sql/SqlMeta.cpp e663adf > > Diff: http://git.reviewboard.kde.org/r/104369/diff/ > > > Testing > ------- > > The existing test cases work. > It has been tried on numerous songs successfully on my computer. > > > Thanks, > > Phalgun Guduthur > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
