----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102110/#review9990 -----------------------------------------------------------
This review has been submitted with commit 21f0003cf22d965f45ef7f2df9e653ddfa5b116f by Ralf Engels to branch master. - Commit Hook On July 28, 2011, 1:38 p.m., Modestas Vainius wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102110/ > ----------------------------------------------------------- > > (Updated July 28, 2011, 1:38 p.m.) > > > Review request for Amarok. > > > Description > ------- > > There were some issues mostly when playing streams. Lyrics would stuck with > empty text and wouldn't autorefresh until the track was changed or manually > refreshed. That's because cachedLyrics() is always empty for streams. > Therefore it makes sense to additionally check if either artist or track > title have changed as well. > > > Diffs > ----- > > src/context/engines/lyrics/LyricsEngine.cpp 2abeb6d > > Diff: http://git.reviewboard.kde.org/r/102110/diff/diff > > > Testing > ------- > > > Thanks, > > Modestas Vainius > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
