----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102181/#review5916 -----------------------------------------------------------
This review has been submitted with commit 01d13d4becb370cd80e433303ec170a7d2eba066 by Bart Cerneels to branch master. - Commit On Aug. 2, 2011, 2:38 p.m., Sandeep Raghuraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102181/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2011, 2:38 p.m.) > > > Review request for Amarok. > > > Summary > ------- > > Improved isPlayable functions for some classes derived from Meta::Track. > TrackNavigator will not queue unplayable tracks. > StandardTrackNavigator::chooseNextTrack now skips unplayable tracks and > returns the next playable track in the list. Unplayable tracks are grayed in > the playlist to show that they are unavailable. > > > This addresses bug 263640. > https://bugs.kde.org/show_bug.cgi?id=263640 > > > Diffs > ----- > > src/core-impl/collections/audiocd/AudioCdMeta.cpp c4a791e > src/core-impl/collections/daap/CMakeLists.txt c60b371 > src/core-impl/collections/daap/DaapMeta.cpp b8431dd > src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 5daed6d > src/core-impl/collections/upnpcollection/UpnpMeta.cpp 4d44acf > src/core-impl/meta/file/File.cpp d8d516e > src/core-impl/meta/stream/Stream.cpp 5a6659c > src/playlist/navigators/StandardTrackNavigator.cpp 9675876 > src/playlist/navigators/TrackNavigator.cpp 6fbfc55 > src/playlist/view/PlaylistViewCommon.cpp db300a3 > src/playlist/view/listview/PrettyItemDelegate.cpp 08b0724 > src/services/ampache/AmpacheMeta.h fa104ec > src/services/ampache/AmpacheMeta.cpp 2b85a7b > src/services/ampache/CMakeLists.txt e3d09af > src/services/lastfm/meta/LastFmMeta.cpp 055dfef > > Diff: http://git.reviewboard.kde.org/r/102181/diff > > > Testing > ------- > > Tested with local files only. Cannot test with audio CD's since mine doesn't > work. Going to test Upnp and Ampache tracks and Daap tracks if possible. > > > Thanks, > > Sandeep > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
