----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101745/ -----------------------------------------------------------
(Updated June 24, 2011, 10:21 a.m.) Review request for Amarok. Changes ------- Fixed ScannerJob progress. Summary (updated) ------- Removes all calls to The::statusbar() and the StatusBar class itself. Messages and progress now all use Amarok::Compoments::logger() and methods from core/interface/Logger.h. Made Amarok::Logger a pure virtual class, not deriving from QObject so multiple inheritance is possible. Patch also committed to http://quickgit.kde.org/?p=clones%2Famarok%2Fshanachie%2Fstecchinos-amarok.git&a=shortlog&h=refs/heads/BrowserDock_Logger Diffs (updated) ----- src/CMakeLists.txt 44c9df6 src/EngineController.cpp 2d22b80 src/MainWindow.cpp dc1b1a6 src/MountPointManager.cpp cb9b076 src/browsers/BrowserDock.h d172fcc src/browsers/BrowserDock.cpp e1aafb0 src/browsers/BrowserMessageArea.h PRE-CREATION src/browsers/BrowserMessageArea.cpp PRE-CREATION src/browsers/filebrowser/FileView.cpp f5fe169 src/browsers/playlistbrowser/UserPlaylistCategory.cpp bc11a71 src/core-impl/collections/daap/DaapCollection.cpp d3ea3a9 src/core-impl/collections/daap/daapreader/Reader.cpp e4c6b64 src/core-impl/collections/db/ScanManager.h 0d34ff6 src/core-impl/collections/db/ScanManager.cpp b5da510 src/core-impl/collections/db/sql/SqlCollectionLocation.cpp fc4464d src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp 216b200 src/core-impl/collections/mediadevicecollection/MediaDeviceCollectionLocation.cpp 0a902a2 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.h d6ad43e src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp ec0dcbc src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp be0c918 src/core-impl/collections/support/CollectionLocationDelegateImpl.cpp 01e8f22 src/core-impl/collections/support/FileCollectionLocation.cpp d743c9d src/core-impl/collections/support/TrashCollectionLocation.cpp 26859c5 src/core-impl/collections/umscollection/handler/UmsHandler.h 44cacf6 src/core-impl/collections/upnpcollection/UpnpBrowseCollection.h 03b26f1 src/core-impl/collections/upnpcollection/UpnpBrowseCollection.cpp e6b4338 src/core-impl/collections/upnpcollection/UpnpSearchCollection.cpp 8525039 src/core-impl/logger/ProxyLogger.h d02ff73 src/core-impl/logger/ProxyLogger.cpp 9f8923a src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 5e35e8b src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 385a6ac src/core/interfaces/Logger.h e89aaf4 src/dynamic/BiasedPlaylist.h 52f7548 src/dynamic/BiasedPlaylist.cpp e40a1ab src/playlist/layouts/LayoutManager.cpp 80f74d9 src/playlistgenerator/ConstraintSolver.cpp 3d2d960 src/playlistgenerator/Preset.h ecf5147 src/playlistgenerator/Preset.cpp ffec0d3 src/playlistgenerator/PresetModel.cpp 269c1af src/services/lastfm/meta/MultiPlayableCapabilityImpl_p.h b407601 src/services/magnatune/MagnatuneAlbumDownloader.cpp 564809b src/services/magnatune/MagnatuneDownloadHandler.cpp a01e7c7 src/services/mp3tunes/Mp3tunesService.cpp 6ef5e27 src/services/mp3tunes/Mp3tunesServiceCollectionLocation.cpp acfe9db src/services/mp3tunes/Mp3tunesWorkers.h be43911 src/services/mp3tunes/Mp3tunesWorkers.cpp ec037b5 src/services/opmldirectory/OpmlDirectoryInfoParser.cpp 08a9c81 src/statusbar/CompoundProgressBar.h d08236e src/statusbar/CompoundProgressBar.cpp 9d7daf5 src/statusbar/LongMessageWidget.h b70e937 src/statusbar/LongMessageWidget.cpp 01274db src/statusbar/ProgressBar.h 182575a src/statusbar/StatusBar.h 5fd3996 src/statusbar/StatusBar.cpp e977223 Diff: http://git.reviewboard.kde.org/r/101745/diff Testing ------- SqlPodcastProvider, AmarokStatusbarScript. Could not test all users of The::statusBar() like MP3Tunes, UPnP, MediaDevice, etc. In depth testing is required for risk of regressions. Thanks, Bart
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
