> On May 15, 2011, 9:56 a.m., Ralf Engels wrote: > > Shouldn't we rather change the location of the desktop file than the mpris > > identifier. > > After all Amarok is not really part of kde4. > >
It is not really about being part of KDE4 Software Compilation. It is my understanding that all applications which uses kdelibs CMake facilities will install their desktop files in $prefix/share/applications/kde4. - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100965/#review3330 ----------------------------------------------------------- On March 29, 2011, 10:52 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100965/ > ----------------------------------------------------------- > > (Updated March 29, 2011, 10:52 a.m.) > > > Review request for Amarok. > > > Summary > ------- > > Prepending "kde4" to the desktop file name is necessary for Ubuntu Sound Menu > (and maybe others) to find Amarok desktop file because it is installed in > $prefix/share/applications/kde4, not in $prefix/share/applications. > > See > http://standards.freedesktop.org/menu-spec/1.0/go01.html#term-desktop-file-id > for more info. > > > Diffs > ----- > > src/dbus/mpris2/Mpris2DBusHandler.cpp bd69a05 > > Diff: http://git.reviewboard.kde.org/r/100965/diff > > > Testing > ------- > > > Thanks, > > Aurélien > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
