----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101363/ -----------------------------------------------------------
Review request for Amarok. Summary ------- I have looked into https://bugs.kde.org/show_bug.cgi?id=232051 a bit and there are different places where the crash happens although one is far more common. I attach a patch with a preliminary fix. From experience it now crashes 20% of the time when unplugging once scanning. There might be a drawback to the patch as Amarok crashed once when unplugging the device long after it had been scanned. This addresses bug 232051. https://bugs.kde.org/show_bug.cgi?id=232051 Diffs ----- src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp c6b5f79 Diff: http://git.reviewboard.kde.org/r/101363/diff Testing ------- Plugging and unplugging media player device when scanning numerous times. Thanks, Matthieu
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel