-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100806/
-----------------------------------------------------------
Review request for Amarok.
Summary
-------
There was a discussion a few months ago about using composer tags in last.fm
scrobbling. The patch did what I wanted it to, but after being checked in it
was reverted when some people complained. Fair enough. I have got round to
adding a config option for this behaviour.
Feedback in particular: I am new to amarok, so might be using the config system
incorrectly. It does work though.
Behaviour implemented: when config option is set, scrobble composer
preferentially to artist; when not set, always use artist data (default, and
same behaviour as before)
This addresses bug 254580.
https://bugs.kde.org/show_bug.cgi?id=254580
Diffs
-----
src/amarokconfig.kcfg 1268c33
src/services/lastfm/LastFmConfigWidget.ui a6e50d3
src/services/lastfm/LastFmService.h 8c30a5d
src/services/lastfm/LastFmService.cpp b61a8f4
src/services/lastfm/LastFmServiceConfig.h 99b46c2
src/services/lastfm/LastFmServiceConfig.cpp 6ac3ff6
src/services/lastfm/LastFmServiceSettings.cpp d464c89
src/services/lastfm/ScrobblerAdapter.cpp 940d0c4
Diff: http://git.reviewboard.kde.org/r/100806/diff
Testing
-------
It seems to work. Scrobbles as expected with option set and not set, and config
is correctly saved between restarts of amarok when set and not set.
Thanks,
Nicholas
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
