----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100372/#review860 -----------------------------------------------------------
Ship it! Looks good. - Soren On Jan. 12, 2011, 5:39 p.m., Edward Hades Toroshchin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100372/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2011, 5:39 p.m.) > > > Review request for Amarok and Soren Harward. > > > Summary > ------- > > Currently APG creates default example presets if it fails to load a file that > contains "playlistgenerator.xml" in the name. That's not nice. > > > Diffs > ----- > > src/playlistgenerator/PresetModel.h d526378 > src/playlistgenerator/PresetModel.cpp eb02bcb > > Diff: http://git.reviewboard.kde.org/r/100372/diff > > > Testing > ------- > > It compiles, it creates example presets if playlistgenerator.xml is missing. > > > Thanks, > > Edward Hades > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
