----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100182/#review451 -----------------------------------------------------------
- Maximilian On 2010-12-01 17:06:40, Ralf Engels wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100182/ > ----------------------------------------------------------- > > (Updated 2010-12-01 17:06:40) > > > Review request for Amarok. > > > Summary > ------- > > Remove addMatchTo and addMatch( Meta::DataPtr ) > Both functions were effectively used at only one place but were implemented > at several places. > Removing the functions cleans up the api. > > Summary: > 32 files changed, 47 insertions(+), 229 deletions(-) > > > Diffs > ----- > > src/browsers/CollectionTreeItem.h c7748d1 > src/browsers/CollectionTreeItem.cpp 770c8fe > src/browsers/CollectionTreeItemModelBase.cpp 6f76380 > src/browsers/CollectionTreeView.cpp cc4d93e > src/core-impl/collections/db/sql/SqlMeta.cpp 967b742 > src/core-impl/collections/db/sql/SqlQueryMaker.h 3fdf8f4 > src/core-impl/collections/db/sql/SqlQueryMaker.cpp ff03431 > src/core-impl/collections/nepomukcollection/NepomukQueryMaker.h 307a5c6 > src/core-impl/collections/nepomukcollection/NepomukQueryMaker.cpp 9a2bbbe > src/core-impl/collections/playdarcollection/PlaydarQueryMaker.h fdd62c0 > src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp 2e913e4 > src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h > c825f65 > src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp > e8a26dd > src/core-impl/collections/support/MemoryQueryMaker.h 1d11435 > src/core-impl/collections/support/MemoryQueryMaker.cpp d413d18 > src/core-impl/collections/support/XmlQueryWriter.h e3d2c35 > src/core-impl/collections/support/XmlQueryWriter.cpp ec75198 > src/core-impl/collections/upnpcollection/UpnpQueryMaker.h 234f337 > src/core-impl/collections/upnpcollection/UpnpQueryMaker.cpp 68c11dd > src/core/collections/MetaQueryMaker.h 9c1d0ba > src/core/collections/MetaQueryMaker.cpp d09950f > src/core/collections/QueryMaker.h 409dc85 > src/core/meta/Meta.h de9d193 > src/core/meta/Meta.cpp b5f4002 > src/services/DynamicServiceQueryMaker.h 7a8a9e8 > src/services/DynamicServiceQueryMaker.cpp f47a6f9 > src/services/ServiceSqlQueryMaker.h dc586f0 > src/services/ServiceSqlQueryMaker.cpp 93a3cef > src/services/scriptable/ScriptableServiceQueryMaker.h d68e303 > src/services/scriptable/ScriptableServiceQueryMaker.cpp f4c7333 > tests/core-impl/collections/db/sql/TestSqlQueryMaker.h f3c3d2c > tests/core-impl/collections/db/sql/TestSqlQueryMaker.cpp 98990d5 > > Diff: http://git.reviewboard.kde.org/r/100182/diff > > > Testing > ------- > > Auto tests and playing around with collection view. > > > Thanks, > > Ralf > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
