> On 2010-11-28 13:03:52, Alexander Potashev wrote: > > I see white text instead of black, and it may be hard to read it on light > > blue background. Could you please make the text always black? > > Leo Franchi wrote: > Are you testing this patch? This has gone into amarok git and had a lot > of updates there, so please test that instead. > > Alexander Potashev wrote: > No, I'm not testing it. I use ReviewBoard as an alternative to KDE > Bugzilla ;) > > Leo Franchi wrote: > Commenting on a closed review request is not the appropriate way of > reporting bugs. I don't know what version you're running, if you're running > this patch or git, etc. Please file a bug! :)
Last time reporting a bug here worked well ;) Ok, I've reported this at bugs.kde.org: https://bugs.kde.org/show_bug.cgi?id=258234 - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100117/#review429 ----------------------------------------------------------- On 2010-11-01 18:36:05, Rainer Sigle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100117/ > ----------------------------------------------------------- > > (Updated 2010-11-01 18:36:05) > > > Review request for Amarok. > > > Summary > ------- > > This patch adds a new applet to the Amarok context menu: "Tabs". It's > designed for guitar and bass-players, as it downloads and displays tablature > information for the current song. Directly playing along a song has therefore > never been easier. > > The tab data is currently fetched from two sites: www.ultimateguitar.com and > www.fretplay.com. As these provide no direct API, the tab data is extracted > using some simple HTML parsing. Multiple results, e.g. versions of the tab, > are stored and can be choosen from a list. A settings dialog allows to define > the type of tabs to be fetched. In this patch we've guitar and bass, but it > could be extended to e.g. drums or piano in the future. Furthermore I've > added a reload button which allows to easily refine the criteria for the > tab-search. This can be used e.g. when no tab-results were found because the > song name contains fragments like (live), remix, etc. > > I'll send some new png-images to amarok devel mailinglist because I was not > able to correctly include these binary files into the patch. Please be aware > that I don't know if there are any copyright restrictions on these bitmaps! > Maybe they can be replaced with some KDE/Plasma specific images. > Unfortunately I didn't find anything appropriate. > > Thanks for any feedback on this... > > By the way: Also big Thanks! to all Amarok devs and supporters for their > great work. I love this application. > > > Diffs > ----- > > src/context/applets/CMakeLists.txt 98bdd2b > src/context/applets/tabs/CMakeLists.txt PRE-CREATION > src/context/applets/tabs/ReloadEditDialog.ui PRE-CREATION > src/context/applets/tabs/TabsApplet.h PRE-CREATION > src/context/applets/tabs/TabsApplet.cpp PRE-CREATION > src/context/applets/tabs/TabsItem.h PRE-CREATION > src/context/applets/tabs/TabsItem.cpp PRE-CREATION > src/context/applets/tabs/TabsSettings.ui PRE-CREATION > src/context/applets/tabs/TabsView.h PRE-CREATION > src/context/applets/tabs/TabsView.cpp PRE-CREATION > src/context/applets/tabs/amarok-context-applet-tabs.desktop PRE-CREATION > src/context/applets/tabs/amarok-tabs-bass.png PRE-CREATION > src/context/applets/tabs/amarok-tabs-drum.png PRE-CREATION > src/context/applets/tabs/amarok-tabs-guitar.png PRE-CREATION > src/context/applets/tabs/amarok-tabs-piano.png PRE-CREATION > src/context/engines/CMakeLists.txt c1f029e > src/context/engines/tabs/CMakeLists.txt PRE-CREATION > src/context/engines/tabs/TabsEngine.h PRE-CREATION > src/context/engines/tabs/TabsEngine.cpp PRE-CREATION > src/context/engines/tabs/TabsInfo.h PRE-CREATION > src/context/engines/tabs/amarok-data-engine-tabs.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/100117/diff > > > Testing > ------- > > used and tested during the last months, works fine for me > > > Screenshots > ----------- > > Tabs Applet > http://git.reviewboard.kde.org/r/100117/s/9/ > > > Thanks, > > Rainer > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
